Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add right sidebar content for prismic content #2795

Open
wants to merge 11 commits into
base: staging
Choose a base branch
from

Conversation

clari182
Copy link
Collaborator

@clari182 clari182 commented May 21, 2024

In order for the right side Content to work with Prismic rich text, we need to add IDs to headers (h1 and h2) for anchors to work. Since richtext is not Markdown, this needs to be done manually (without any plugins)

Working examples:
https://pr-2795--staging-aiid.netlify.app/blog/incident-report-2024-january/
https://pr-2795--staging-aiid.netlify.app/about/

Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.73%. Comparing base (d5eba4f) to head (3338227).
Report is 1 commits behind head on staging.

Additional details and impacted files
@@           Coverage Diff            @@
##           staging    #2795   +/-   ##
========================================
  Coverage    96.73%   96.73%           
========================================
  Files           35       35           
  Lines         9408     9408           
  Branches       130      182   +52     
========================================
  Hits          9101     9101           
  Misses         307      307           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented May 21, 2024

Passing run #2478 ↗︎

0 485 248 0 Flakiness 0

Details:

Add right sidebar content for prismic content
Project: aiid-site Commit: 6fc0dacfd8
Status: Passed Duration: 17:50 💡
Started: May 22, 2024 3:04 PM Ended: May 22, 2024 3:22 PM

Review all test suite changes for PR #2795 ↗︎

@clari182
Copy link
Collaborator Author

clari182 commented Jun 3, 2024

@cesarvarela ready for another review!

Copy link
Collaborator

@cesarvarela cesarvarela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I missed this review.

Please migrate the test to Playwright.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants