Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add date range selector histogram #2812

Open
wants to merge 7 commits into
base: staging
Choose a base branch
from

Conversation

lmcnulty
Copy link
Collaborator

@lmcnulty lmcnulty commented May 31, 2024

Copy link

cypress bot commented May 31, 2024

6 failed tests on run #2797 ↗︎

6 379 238 0 Flakiness 0

Details:

Add date range selector histogram
Project: aiid-site Commit: 2c962df939
Status: Failed Duration: 11:12 💡
Started: Jun 20, 2024 8:53 PM Ended: Jun 20, 2024 9:04 PM
Failed  classificationsEditor.cy.js • 4 failed tests • Cypress e2e tests

View Output

Test Artifacts
Classifications Editor > Should show classifications editor on report page and add a new classification Test Replay
Classifications Editor > Should properly display and store CSETv0 classification values Test Replay
Classifications Editor > Should properly display and store GMF classification values Test Replay
Classifications Editor > Should properly display and store CSETv1 classification values Test Replay
Failed  landingPage.cy.js • 1 failed test • Cypress e2e tests

View Output

Test Artifacts
The Landing page > Should submit a report through the Quick Add form Test Replay
Failed  login.cy.js • 1 failed test • Cypress e2e tests

View Output

Test Artifacts
Login > Should display error toast if the email address or password is incorrect Test Replay

Review all test suite changes for PR #2812 ↗︎

Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 62.88660% with 36 lines in your changes missing coverage. Please review.

Project coverage is 73.48%. Comparing base (3e0f756) to head (2c962df).
Report is 3 commits behind head on staging.

Files Patch % Lines
.../src/components/discover/filterTypes/RangeInput.js 58.62% 33 Missing and 3 partials ⚠️

❗ There is a different number of reports uploaded between BASE (3e0f756) and HEAD (2c962df). Click for more details.

HEAD has 1 upload less than BASE | Flag | BASE (3e0f756) | HEAD (2c962df) | |------|------|------| ||3|2|
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2812      +/-   ##
===========================================
- Coverage    81.95%   73.48%   -8.48%     
===========================================
  Files          243      236       -7     
  Lines        12583    12095     -488     
  Branches      2476     2286     -190     
===========================================
- Hits         10313     8888    -1425     
- Misses        2033     2851     +818     
- Partials       237      356     +119     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@clari182 clari182 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
The only issue I found is that the left side of the range is not clearing when Clearing the filter, and neither when Clearing all filters. It stays selected.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants