Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display incidents instead of reports for similar/dissimilar incidents #2815

Draft
wants to merge 10 commits into
base: staging
Choose a base branch
from

Conversation

clari182
Copy link
Collaborator

@clari182 clari182 commented Jun 4, 2024

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 2.77778% with 35 lines in your changes missing coverage. Please review.

Project coverage is 87.33%. Comparing base (0470e73) to head (37eb9f7).
Report is 2 commits behind head on staging.

Files with missing lines Patch % Lines
...tsby-site/src/components/incidents/IncidentForm.js 0.00% 27 Missing and 3 partials ⚠️
...gatsby-site/src/components/RelatedIncidentsArea.js 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2815      +/-   ##
===========================================
- Coverage    96.49%   87.33%   -9.16%     
===========================================
  Files           30      115      +85     
  Lines         8759    11017    +2258     
  Branches       128      954     +826     
===========================================
+ Hits          8452     9622    +1170     
- Misses         307     1256     +949     
- Partials         0      139     +139     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clari182
Copy link
Collaborator Author

clari182 commented Jun 5, 2024

Hey @datherton09 , can you take a look at this PR and let me know if the new design for similar/dissimilar looks ok to you?
The test URL is https://pr-2815--staging-aiid.netlify.app/
The changes are

  • It only displays incidents instead of reports when searching by incident ID
  • New tooltip with information on how to use that functionality
  • Some minor design changes
    Let me know what you think. Thanks!!
image

@datherton09
Copy link
Collaborator

@clari182 Nice! Thanks :) Where is the tooltip located?

@clari182
Copy link
Collaborator Author

clari182 commented Jun 6, 2024

@datherton09 the tooltip is located right next to Search similar incident ID

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants