Deploy to Production – 2024-06-18 #2882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pdcp1
commented
Jun 17, 2024
•
pdcp1
commented
- Add playwright tests for global search #2856
- Update checklists logged out message #2820
- Edit taxonomy by default when adding #2814
- Migrate entity.cy to entity.spec.ts using Playwright #2869
- Fix live incident data not loading #2883
- Migrate entity.cy to entity.spec.ts using Playwright #2869
- Make Cypress tests fail faster #2865
- Update tests to new fixtures #2885
- Remove unused fields from news digest query #2881
…ests Add playwright tests for global search
…ssage Update checklists logged out message
…adding Edit taxonomy by default when adding
Migrate entity.cy to entity.spec.ts using Playwright
Co-authored-by: Kevin <kepae@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2882 +/- ##
===========================================
- Coverage 99.46% 52.19% -47.28%
===========================================
Files 12 219 +207
Lines 4893 6849 +1956
Branches 55 2140 +2085
===========================================
- Hits 4867 3575 -1292
- Misses 26 2907 +2881
- Partials 0 367 +367 ☔ View full report in Codecov by Sentry. |
28 failed tests on run #2792 ↗︎
Details:
|
||||||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Checklists App Index > Should sort checklists |
Test Replay
|
|
| Checklists App Index > Should show toast on error fetching risks |
Test Replay
|
|
incidents/history.cy.js • 1 failed test • Cypress e2e tests
| Test | Artifacts | |
|---|---|---|
| Incidents > Successfully loads |
Test Replay
|
|
apps/submitted.cy.js • 1 failed test • Cypress e2e tests
| Test | Artifacts | |
|---|---|---|
| Submitted reports > Loads submissions |
Test Replay
|
|
landingPage.cy.js • 1 failed test • Cypress e2e tests
| Test | Artifacts | |
|---|---|---|
| The Landing page > Should submit a report through the Quick Add form |
Test Replay
|
|
The first 5 failed specs are shown, see all 18 specs in Cypress Cloud.
Review all test suite changes for PR #2882 ↗︎
* Make cypress tests fail faster * Remove custom retries
* Add missing wait request * Add missing wait * Make intercept alias obligatory * Increase local timeout * Prevent test from writing to log history * Update tests * Refactor conditional tests to use fixtures * Undo timeout change
…digest-query Remove unused fields from news digest query
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.