Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing translations dashboard #2981

Conversation

lmcnulty
Copy link
Collaborator

@lmcnulty lmcnulty commented Jul 17, 2024


image


image


image

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.35%. Comparing base (c966cb5) to head (a199623).
Report is 86 commits behind head on staging.

Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2981      +/-   ##
===========================================
- Coverage    86.42%   85.35%   -1.07%     
===========================================
  Files          181      148      -33     
  Lines        11380     9683    -1697     
  Branches      2026     1479     -547     
===========================================
- Hits          9835     8265    -1570     
+ Misses        1396     1250     -146     
- Partials       149      168      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lmcnulty lmcnulty marked this pull request as ready for review September 3, 2024 16:48
@lmcnulty lmcnulty requested review from kepae and a team and removed request for kepae September 3, 2024 16:49
Copy link
Collaborator

@cesarvarela cesarvarela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good I would add some tests later, but since this is not critical


const getKeys = (object) => new FunctionalSet(Object.keys(object))

class FunctionalSet extends Set {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting mini lodash here

@cesarvarela cesarvarela merged commit b1266b6 into responsible-ai-collaborative:staging Sep 10, 2024
7 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants