Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow whitespaces in device search (#869) #870

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

NarrowCode
Copy link
Contributor

✨ Pull Request

📓 Referenced Issue

fixes #869.

ℹ️ About the PR

Search input is now stored "raw", input sanitization is done before filtering.

🖼️ Testing Scenarios / Screenshots

Whitespace characters can now be entered as expected, filtering result should not be affected.

Copy link
Collaborator

@manojVivek manojVivek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, and thanks for the quick turnaround on this one!
Looking forward to more like this. 🎉

@manojVivek manojVivek merged commit e043348 into responsively-org:main Mar 22, 2023
@manojVivek
Copy link
Collaborator

@all-contributors Please add @NarrowCode for code.

@allcontributors
Copy link
Contributor

@manojVivek

I've put up a pull request to add @NarrowCode! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Device Manager search with spaces
2 participants