Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sponsor button in release note popup #940 #946

Merged

Conversation

ReshadSadik
Copy link
Contributor

✨ Pull Request

📓 Referenced Issue

This changes resolves #940

About the PR :

Added "Sponsor" button in the ReleaseNotes component which will take us to the website sponsor page .

Here is a preview of the Release Notes popup .

image

Tested the app after adding new button and everything seems to be working properly .

@CLAassistant
Copy link

CLAassistant commented May 30, 2023

CLA assistant check
All committers have signed the CLA.

@manojVivek
Copy link
Collaborator

manojVivek commented May 31, 2023

@ReshadSadik Great work, implementing this so quickly! 👏🏼 👏🏼

Just a minor feedback on the design, I think it would be better if move the Close and Full Release Notes button to the left and the Sponsor button to the right and modify the text on the button like below:

------------------------------------------------------------------------------------------------------
| |Release Notes|   |Close|                                               |Support Responsively App| |
------------------------------------------------------------------------------------------------------

@ReshadSadik
Copy link
Contributor Author

@manojVivek New changes are pushed to the branch .
Here's how it looks .

image

Copy link
Collaborator

@manojVivek manojVivek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you so much for the contribution and looking forward to more like this! 🎉

@manojVivek manojVivek merged commit 29bed16 into responsively-org:main May 31, 2023
@manojVivek
Copy link
Collaborator

@all-contributors Please add @ReshadSadik for code.

@allcontributors
Copy link
Contributor

@manojVivek

I've put up a pull request to add @ReshadSadik! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a link to website's sponsors page in the ReleaseNotes component
3 participants