Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRestPatternMask is not pure virtual anymore #304

Merged
merged 8 commits into from
Sep 28, 2022
Merged

Conversation

jgalan
Copy link
Member

@jgalan jgalan commented Sep 21, 2022

jgalan Ok: 18

TRestPatternMask defines common members for any TRestPatternMask. TRestPatternMask was pure virtual so in order to use one had to chose a particular pattern (Grid/Stripped/../Combined).

Now it is also possible to do not define a pattern, and thus there will be no pattern, the only selection will be the limits of the pattern defined by fMaxRadius and fOffset.

@jgalan
Copy link
Member Author

jgalan commented Sep 21, 2022

@nkx111 Any idea why the pipeline is failing here?

@jgalan jgalan merged commit 4cd1923 into master Sep 28, 2022
@jgalan jgalan deleted the jgalan_new_masks branch September 28, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants