Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fix for tritium decay #68

Merged
merged 4 commits into from
Sep 24, 2022
Merged

Added fix for tritium decay #68

merged 4 commits into from
Sep 24, 2022

Conversation

lobis
Copy link
Member

@lobis lobis commented Sep 23, 2022

lobis Ok: 40

Fixes #67

For more information about the solution read https://geant4-forum.web.cern.ch/t/triton-decay-with-rdecay01-example/2616.

Tritium decay can now be used via the following option on the physics list:

<physicsList name="G4RadioactiveDecay">
    <option name="TritiumDecay" value="false"/>
</physicsList>

If the primary particle source is H3, then this option is enabled by default. It can still be explicitly disabled. It is disabled by default for other primary particle sources.

I could not make it work for old Geant4 versions (namely the 10.4.3 reference version). It can probably by implemented if anyone wants to do the fix.

@lobis lobis requested review from glorialuzon, jgalan, juanangp and a team September 23, 2022 16:42
@lobis lobis marked this pull request as ready for review September 23, 2022 16:43
@lobis lobis added enhancement New feature or request development invalid This doesn't seem right labels Sep 23, 2022
Copy link
Contributor

@glorialuzon glorialuzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should compare results: this activation versus the old one H3 source using an histogram. In the past the H3 decay of geant4 didn't produce any event. Using it as a source in the gas the full decay spectrum is expected.
Not sure if it should be also activated in case of neutron interactions (cosmogenic production)

@lobis
Copy link
Member Author

lobis commented Sep 24, 2022

You should compare results: this activation versus the old one H3 source using an histogram. In the past the H3 decay of geant4 didn't produce any event. Using it as a source in the gas the full decay spectrum is expected.
Not sure if it should be also activated in case of neutron interactions (cosmogenic production)

I have checked the spectrum and visually it looks identical to the one in the literature. I will share a screenshot in this PR later on.

I think the root histogram should be deprecated in favour of this approach as it seems more natural for users and it was only introduced as a workaround.

@lobis lobis merged commit 3060283 into master Sep 24, 2022
@lobis lobis deleted the lobis-decay branch September 24, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development enhancement New feature or request invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tritium decay not working properly
2 participants