Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selecting gdml volume will also choose logical volume if physical doe… #98

Merged
merged 2 commits into from
Mar 2, 2023

Conversation

lobis
Copy link
Member

@lobis lobis commented Mar 2, 2023

lobis Ok: 24

Using the gdml generator will now use a logical volume (if only one physical volume matches) instead of throwing error.

@lobis lobis requested review from jgalan and juanangp March 2, 2023 13:28
@lobis
Copy link
Member Author

lobis commented Mar 2, 2023

rest-for-physics/framework#381 should fix the failing pipeline

@lobis lobis marked this pull request as ready for review March 2, 2023 16:08
@lobis lobis enabled auto-merge March 2, 2023 16:09
@lobis lobis requested review from a team and KonradAltenmueller March 2, 2023 16:41
@lobis lobis merged commit 86b8b09 into master Mar 2, 2023
@lobis lobis deleted the lobis-from-gdml branch March 2, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants