Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RESTEASY-3432] Add a channel for overriding the version of RESTEasy … #4021

Merged
merged 1 commit into from
May 10, 2024

Conversation

jamezp
Copy link
Contributor

@jamezp jamezp commented Feb 8, 2024

@jamezp jamezp force-pushed the RESTEASY-3432 branch 2 times, most recently from fe1e80f to f4c7201 Compare March 16, 2024 00:37
@jamezp jamezp force-pushed the RESTEASY-3432 branch 6 times, most recently from 6cf1247 to 05a6a81 Compare May 9, 2024 00:30
@jamezp jamezp marked this pull request as ready for review May 9, 2024 00:33
@jamezp jamezp requested a review from a team as a code owner May 9, 2024 00:33
@liweinan
Copy link
Collaborator

liweinan commented May 9, 2024

Cool!

@jamezp jamezp marked this pull request as draft May 9, 2024 16:25
@jamezp
Copy link
Contributor Author

jamezp commented May 9, 2024

I've moved this back to a draft as I'm going to try the dynamic approach of the manifest and may end up changing the groupId to something like dev.resteasy.channel.

@jamezp jamezp marked this pull request as ready for review May 9, 2024 22:16
@jamezp jamezp force-pushed the RESTEASY-3432 branch 4 times, most recently from 9e33924 to d9b6726 Compare May 10, 2024 00:21
@jamezp
Copy link
Contributor Author

jamezp commented May 10, 2024

The current cloud-tests failures is likely a real issue, see https://wildfly.zulipchat.com/#narrow/stream/184003-galleon/topic/Feature.20Pack.20location.20vs.20GAV.

@@ -247,48 +247,44 @@
<title>Upgrading RESTEasy within WildFly</title>
<para>
RESTEasy is bundled with WildFly. However you may wish to upgrade to the latest version. With
<ulink url="https://docs.wildfly.org/24/Galleon_Guide.html">Galleon</ulink> this makes upgrading RESTEasy
<ulink url="https://docs.wildfly.org/31/Galleon_Guide.html">Galleon</ulink> this makes upgrading RESTEasy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here the Wildfly version doesn't match what used father in the code - 31 vs 32.

…provisioned in WildFly.

https://issues.redhat.com/browse/RESTEASY-3432

Signed-off-by: James R. Perkins <jperkins@redhat.com>
@jamezp jamezp merged commit 055315f into resteasy:main May 10, 2024
24 checks passed
@jamezp jamezp deleted the RESTEASY-3432 branch May 10, 2024 21:15
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants