Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a bunyan serializer for supporting context objects #21

Merged
merged 1 commit into from
Feb 9, 2016

Conversation

DonutEspresso
Copy link
Member

FYI @yunong @micahr supports the new context objects. Might look something like:

[2016-02-08T23:24:09.291Z] ERROR: unit-test/49005 on lgml-aliu: wrapped error (err.code=InternalServer)
    InternalServerError: ISE (foo=bar, baz=1)
        at Context.<anonymous> (/Users/aliu/Sandbox/npm/restify-errors/test/index.js:743:25)
        at callFnAsync (/Users/aliu/Sandbox/npm/restify-errors/node_modules/mocha/lib/runnable.js:306:8)
        at Test.Runnable.run (/Users/aliu/Sandbox/npm/restify-errors/node_modules/mocha/lib/runnable.js:261:7)
        at Runner.runTest (/Users/aliu/Sandbox/npm/restify-errors/node_modules/mocha/lib/runner.js:421:10)
        at /Users/aliu/Sandbox/npm/restify-errors/node_modules/mocha/lib/runner.js:528:12
        at next (/Users/aliu/Sandbox/npm/restify-errors/node_modules/mocha/lib/runner.js:341:14)
        at /Users/aliu/Sandbox/npm/restify-errors/node_modules/mocha/lib/runner.js:351:7
        at next (/Users/aliu/Sandbox/npm/restify-errors/node_modules/mocha/lib/runner.js:283:14)
        at Immediate._onImmediate (/Users/aliu/Sandbox/npm/restify-errors/node_modules/mocha/lib/runner.js:319:5)
        at processImmediate [as _immediateCallback] (timers.js:383:17)
    Caused by: Error: boom
        at Context.<anonymous> (/Users/aliu/Sandbox/npm/restify-errors/test/index.js:742:23)
        at callFnAsync (/Users/aliu/Sandbox/npm/restify-errors/node_modules/mocha/lib/runnable.js:306:8)
        at Test.Runnable.run (/Users/aliu/Sandbox/npm/restify-errors/node_modules/mocha/lib/runnable.js:261:7)
        at Runner.runTest (/Users/aliu/Sandbox/npm/restify-errors/node_modules/mocha/lib/runner.js:421:10)
        at /Users/aliu/Sandbox/npm/restify-errors/node_modules/mocha/lib/runner.js:528:12
        at next (/Users/aliu/Sandbox/npm/restify-errors/node_modules/mocha/lib/runner.js:341:14)
        at /Users/aliu/Sandbox/npm/restify-errors/node_modules/mocha/lib/runner.js:351:7
        at next (/Users/aliu/Sandbox/npm/restify-errors/node_modules/mocha/lib/runner.js:283:14)
        at Immediate._onImmediate (/Users/aliu/Sandbox/npm/restify-errors/node_modules/mocha/lib/runner.js:319:5)
        at processImmediate [as _immediateCallback] (timers.js:383:1

@micahr
Copy link
Member

micahr commented Feb 9, 2016

Looks great! Can't wait to make use of this.

@yunong
Copy link
Member

yunong commented Feb 9, 2016

LGTM, ship it!

DonutEspresso added a commit that referenced this pull request Feb 9, 2016
add a bunyan serializer for supporting context objects
@DonutEspresso DonutEspresso merged commit 21ebd5c into master Feb 9, 2016
@DonutEspresso DonutEspresso deleted the serializer branch February 9, 2016 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants