Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove duplication of serialized Error properties #90

Merged
merged 1 commit into from
May 30, 2018
Merged

fix: remove duplication of serialized Error properties #90

merged 1 commit into from
May 30, 2018

Conversation

DonutEspresso
Copy link
Member

In 6.x restify-errors legacy context option was implemented using verror info. This caused duplication of properties as we serialized both independently:

MultiError 2 of 3: InternalServerError: ISE (foo="bar", baz=1foo="bar", baz=1)

MultiError 2 of 3: InternalServerError: ISE (foo="bar", baz=1)

This PR merges the two buckets into a single bucket (as verror does) before serialization.

@coveralls
Copy link

coveralls commented May 30, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.03%) to 98.222% when pulling 1a65dba on clean-serializer into 31a8a89 on master.

@DonutEspresso DonutEspresso merged commit 1da7c76 into master May 30, 2018
@DonutEspresso DonutEspresso deleted the clean-serializer branch May 30, 2018 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunong yunong Awaiting requested review from yunong

@hekike hekike Awaiting requested review from hekike

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DonutEspresso @coveralls