Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restify test fails on Node 4 #916

Closed
micahr opened this issue Sep 18, 2015 · 5 comments
Closed

Restify test fails on Node 4 #916

micahr opened this issue Sep 18, 2015 · 5 comments
Assignees

Comments

@micahr
Copy link
Member

micahr commented Sep 18, 2015

https://travis-ci.org/restify/node-restify/jobs/79522234

✖ GH-149 limit request body size
AssertionError: 500 == 413
    at Object.equal (/home/travis/build/restify/node-restify/node_modules/nodeunit/lib/types.js:83:39)
    at ClientRequest.<anonymous> (/home/travis/build/restify/node-restify/test/server.test.js:804:11)
    at ClientRequest.g (events.js:260:16)
    at emitOne (events.js:77:13)
    at ClientRequest.emit (events.js:169:7)
    at HTTPParser.parserOnIncomingClient (_http_client.js:415:21)
    at HTTPParser.parserOnHeadersComplete (_http_common.js:88:23)
    at Socket.socketOnData (_http_client.js:305:20)
    at emitOne (events.js:77:13)
    at Socket.emit (events.js:169:7)

✖ GH-149 limit request body size (json)
AssertionError: 500 == 413
    at Object.equal (/home/travis/build/restify/node-restify/node_modules/nodeunit/lib/types.js:83:39)
    at ClientRequest.<anonymous> (/home/travis/build/restify/node-restify/test/server.test.js:834:11)
    at ClientRequest.g (events.js:260:16)
    at emitOne (events.js:77:13)
    at ClientRequest.emit (events.js:169:7)
    at HTTPParser.parserOnIncomingClient (_http_client.js:415:21)
    at HTTPParser.parserOnHeadersComplete (_http_common.js:88:23)
    at Socket.socketOnData (_http_client.js:305:20)
    at emitOne (events.js:77:13)
    at Socket.emit (events.js:169:7)
@micahr micahr self-assigned this Sep 18, 2015
@micahr
Copy link
Member Author

micahr commented Sep 18, 2015

It looks like Node changed the Http Status codes in 4: nodejs/node@2d9456e#diff-feaf3339998a19f0baf3f82414762c22R53

Specifically related to these tests, there is no longer a RequestEntityTooLargeError, instead it is PayloadTooLarge now.

@micahr
Copy link
Member Author

micahr commented Sep 18, 2015

Here is the PR on the Node side: nodejs/node#1470

@fszakka
Copy link

fszakka commented Sep 18, 2015

just used restify with node 4 and retrieved from mssql over 4000 records no problem.

@micahr
Copy link
Member Author

micahr commented Sep 18, 2015

The problem I'm addressing is that our test suite fails on Node 4.

micahr added a commit that referenced this issue Sep 18, 2015
Fix: HTTP 413 status name (fixes #916)

Fixes #916 by falling back to the old HTTP 413 Error Code if not present
@micahr
Copy link
Member Author

micahr commented Sep 18, 2015

Fixed by #917

@micahr micahr closed this as completed Sep 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants