Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: maintained Node.js (14+) required #1923

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

chore: maintained Node.js (14+) required #1923

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
385d591
chore: bump eslint to ^6.8.0 for emcascriptVersion 2020
rektide Sep 23, 2022
edf9882
chore: drop support for node 10 and 12. resolves #1921.
rektide Sep 23, 2022
1cc3e1a
chore: update supported Node versions in README. resolves #1882.
rektide Sep 23, 2022
82ec9c8
chore: update copyright year in README
rektide Sep 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ var config = {
es6: true
},
parserOptions: {
ecmaVersion: 2018
ecmaVersion: 2020
},
rules: {}
};
Expand Down
12 changes: 10 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,13 +85,21 @@ $ npm install restify

## Supported Node Versions

Restify currently works on Node.js v14.x and v16.x.
Restify aims to support the Node.js LTS (Active and Maintenance) versions along with Node.js current stable version.

| Node Release | Supported in Current Version | Notes |
| :--: | :---: | :---: |
| 18.x | **Yes** | Restify v10.x required. |
| 16.x | **Yes** | |
| 14.x | **Yes** | |
| 12.x | **No** | Use restify v8.x, team will backport critical issues only |
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate line? unless you meant to say 10.x?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| 12.x | **No** | Use restify v8.x, team will backport critical issues only |
| 10.x | **No** | Use restify v8.x, team will backport critical issues only |

| 10.x | **No** | Use restify v8.x, team will backport critical issues only |

## License

The MIT License (MIT)

Copyright (c) 2018 restify
Copyright (c) 2023 restify
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this change


Permission is hereby granted, free of charge, to any person obtaining a copy of
this software and associated documentation files (the "Software"), to deal in
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@
"report-latency": "./bin/report-latency"
},
"engines": {
"node": ">=10.0.0"
"node": ">=14.0.0"
},
"dependencies": {
"assert-plus": "^1.0.0",
Expand Down Expand Up @@ -124,7 +124,7 @@
"chai": "^4.2.0",
"coveralls": "^3.0.3",
"documentation": "^11.0.0",
"eslint": "^5.16.0",
"eslint": "^6.8.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't make an unrelated change unless strictly necessary

"eslint-config-prettier": "^4.3.0",
"eslint-plugin-jsdoc": "^3.15.1",
"eslint-plugin-prettier": "^3.1.0",
Expand Down