Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: qs -> neoqs #1976

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: qs -> neoqs #1976

wants to merge 1 commit into from

Conversation

PuruVJ
Copy link

@PuruVJ PuruVJ commented Aug 7, 2024

Changes

Replaces qs dependency with neoqs

Result:
CleanShot 2024-08-07 at 19 34 35

Graph:

CleanShot 2024-08-07 at 19 35 04

This entire branch will be removed with this PR

@wesleytodd
Copy link
Member

Hey, me again! I happen to also be on the team at Netflix who maintains restify and have exactly the same concerns here that I presented in body-parser. I will not restate them here, but folks can go read them if they like.

@kolbma
Copy link

kolbma commented Oct 2, 2024

There is the change for usage in lib/plugins/formBodyParser.js missing.

diff --git a/lib/plugins/formBodyParser.js b/lib/plugins/formBodyParser.js
index 45731e8..ed19bc5 100644
--- a/lib/plugins/formBodyParser.js
+++ b/lib/plugins/formBodyParser.js
@@ -3,7 +3,7 @@
 'use strict';
 
 var assert = require('assert-plus');
-var querystring = require('qs');
+var qs = require('neoqs/legacy');
 
 var bodyReader = require('./bodyReader');
 var errors = require('restify-errors');
@@ -42,7 +42,7 @@ function urlEncodedBodyParser(options) {
         }
 
         try {
-            var params = querystring.parse(req.body);
+            var params = qs.parse(req.body);
 
             if (opts.mapParams === true) {
                 var keys = Object.keys(params);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants