Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NewDateRegex in StringExtensions #1556 #1557

Merged
merged 2 commits into from
May 5, 2021
Merged

Fix NewDateRegex in StringExtensions #1556 #1557

merged 2 commits into from
May 5, 2021

Conversation

b-c-ds
Copy link
Contributor

@b-c-ds b-c-ds commented Feb 16, 2021

Description

Fixes #1556.

I think it should be a non-breaking change. Feel free to edit this PR as I don't usually do .NET development.

Purpose

This pull request is a:

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@b-c-ds
Fix NewDateRegex in StringExtensions restsharp#1556
c035d73 
Previously it had exponential worst-case complexity and was vulnerable to REDoS.
@b-c-ds
Simple test for new Date(123)
02b4bfd
@alexeyzimarev alexeyzimarev merged commit be39346 into restsharp:dev May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CVE-2021-27293: Fix NewDateRegex
2 participants
@b-c-ds @alexeyzimarev