Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge client- and request-level cookies in the header #2056

Merged
merged 1 commit into from
Apr 9, 2023

Conversation

alexeyzimarev
Copy link
Member

Fixes #2055

Description

  • Merge client- and request-level cookies in one header
  • Also allows using a manually-set cookie header without overriding it
  • Copies response cookies to the client-level container if it is set
  • Dispose the response message if not downloading data, it might've been a memory leak.

Purpose

This pull request is a:

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@alexeyzimarev alexeyzimarev requested a review from kendallb April 5, 2023 12:58
@alexeyzimarev alexeyzimarev merged commit 794348e into dev Apr 9, 2023
@repo-ranger repo-ranger bot deleted the fix-cookie-headers branch April 9, 2023 12:48
@rassilon rassilon mentioned this pull request Aug 17, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client-level cookies override request cookies
1 participant