Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-instate old methods, but as obsolete #2228

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Re-instate old methods, but as obsolete #2228

merged 1 commit into from
Jul 4, 2024

Conversation

matt-richardson
Copy link
Contributor

Description

Release 111.0.0 broke a few scenarios, with the changes in #2078 and #2141.

While both of these changes are valuable, they are breaking changes, and they break code generated by https://github.com/OpenAPITools/openapi-generator.

Purpose

This pull request is a:

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

This PR adds overloads to these methods to re-instate the old behaviour, but flags them as [Obsolete].
(If projects that consume this library has <TreatWarningsAsErrors>true</TreatWarningsAsErrors> in the csproj, then this can be overridden via <<NoWarn>618</NoWarn>)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@alexeyzimarev
Copy link
Member

Nice! Please accept the CLA and I'll merge it.

@alexeyzimarev
Copy link
Member

@matt-richardson 👆 could you please do this? it's a requirement for new contributors from .NET Foundation.

@restsharp restsharp deleted a comment from github-actions bot Jun 26, 2024
@matt-richardson
Copy link
Contributor Author

@matt-richardson 👆 could you please do this? it's a requirement for new contributors from .NET Foundation.

Hi @alexeyzimarev. I'm just waiting for company sign off... It's taking longer than I'd like :(

@matt-richardson
Copy link
Contributor Author

@dotnet-policy-service agree company="Octopus Deploy"

@matt-richardson
Copy link
Contributor Author

@matt-richardson 👆 could you please do this? it's a requirement for new contributors from .NET Foundation.

Hi @alexeyzimarev. I'm just waiting for company sign off... It's taking longer than I'd like :(

Sorry for the delay - all sorted now!

@alexeyzimarev alexeyzimarev merged commit dd52ff6 into restsharp:dev Jul 4, 2024
10 checks passed
@matt-richardson
Copy link
Contributor Author

Thanks for merging and releasing, @alexeyzimarev! Appreciate your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants