Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mejora para listar intents #8

Merged
merged 1 commit into from
Aug 24, 2018
Merged

Mejora para listar intents #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 24 additions & 4 deletions lib/flowex/service/intents.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,31 @@ defmodule Flowex.Service.Intents do
alias Flowex

@doc """
Lista los de intents de un agente.
Lista todos los intents de un agente por pageToken.
"""
@spec list(String.t, String.t, integer, String.t | nil) :: tuple
def list(language \\ "es", view \\ "INTENT_VIEW_UNSPECIFIED", pageSize \\ 1, token \\ nil) do
url = "intents?languageCode=#{language}&intentView=#{view}&pageSize=#{pageSize}&pageToken=#{token}"
@spec list(String.t, String.t, String.t | nil, list) :: tuple
def list(language \\ "es", view \\ "INTENT_VIEW_UNSPECIFIED",
token \\ nil, acc \\ []) do
case list_by_page(language, view, 100, token) do
{:ok, %{"intents" => intents, "nextPageToken" => nextPageToken}} ->
list(language, view, nextPageToken, acc ++ intents)
{:ok, %{"intents" => intents}} ->
{:ok, acc ++ intents}
{:error, error} ->
{:error, error}
end
end

@doc """
Lista los de intents de un agente por pageToken y definiendo tamaño de pagina.
"""
@spec list_by_page(String.t, String.t, integer, String.t | nil) :: tuple
def list_by_page(language \\ "es", view \\ "INTENT_VIEW_UNSPECIFIED",
pageSize \\ 100, token \\ nil) do
url =
"intents?languageCode=#{language}&intentView=#{view}&" <>
"pageSize=#{pageSize}&pageToken=#{token}"

Flowex.request(:get, url, "")
end

Expand Down
5 changes: 2 additions & 3 deletions test/service/intents_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@ defmodule Flowex.Service.IntentsTest do
"name" => "projects/lbot-170189/agent/intents/4cff39af-ba13-4a62-ba6f-8a79f4f5b324",
"priority" => 500000
}
],
"nextPageToken" => "0xFAKETOKEN_Q="
]
}

@intent %{
Expand All @@ -41,7 +40,7 @@ defmodule Flowex.Service.IntentsTest do
end]
}
]) do
assert Intents.list == {:ok, @intents}
assert Intents.list == {:ok, @intents["intents"]}
end
end

Expand Down