Make uuidof() return a static reference #887
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fails on Rust 1.6.0 and is a breaking change anyway, so it will be deferred until winapi 0.4 |
|
Yeah, the plan for this PR was to be a part of #885 "pull requests that have breaking changes", should have mentioned that probably. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These methods currently return GUID by value which causes its unnecessary initialization in the stack instead of referring the value stored in a read-only section e.g.
.rdata.https://rust.godbolt.org/z/7bA-yK - a rough example of what's going on.
This is a breaking change but it shouldn't be something drastically hard to follow. The reference may always be dereferenced and then mutably referenced in rare cases where the actual value or a mutable reference is needed since GUID is
Copy.