Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#13 - Editar cartão #26

Merged
merged 6 commits into from
Oct 18, 2018
Merged

#13 - Editar cartão #26

merged 6 commits into from
Oct 18, 2018

Conversation

mauriciomelo
Copy link
Contributor

@mauriciomelo mauriciomelo commented Sep 30, 2018

  • editar post
  • salvar post editado
  • cancelar post editado
  • melhorar layout do card quando em "modo edição"

Copy link
Contributor

@ThaisaMirely ThaisaMirely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

há 3 formas de integrar a "dependência" do ipfs.
Browserify, WebPack e via tag script.
por que a escolha de usar a abordagem 3? =]

@mauriciomelo
Copy link
Contributor Author

@ThaisaMirely Ótimo questionamento. Preferencialmente deveríamos instalar a partir do npm, mas por conta de alguns conflitos com o create-react-app e a forma como o Uglify está configurado, o app não estava compilando apropriadamente. Faz alguns meses que tive esse problema então vale a pena investigar se a versão mais nova do ipfs e a do create-react-app já funcionam bem juntas.

De qualquer forma adicionar o ipfs via script tag é provisório, criei uma issue para corrigirmos isso: #31

@ThaisaMirely ThaisaMirely merged commit 40fcbba into master Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants