Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken relative links #112

Closed
AdamBrianBright opened this issue Aug 4, 2021 · 3 comments
Closed

Broken relative links #112

AdamBrianBright opened this issue Aug 4, 2021 · 3 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@AdamBrianBright
Copy link

I'm not very familiar with front-end stuff, but from what I see, relative links (to "parent directory") are broken. Maybe dynamic link substitution will solve this?

Example found on your very docs:
../components should in theory lead to retype.com/components, but leads to retype.com/guides/components

(There's a resolved link shown at left bottom corner)

image

P.S. If such behaviour as relative links shouldn't exist, at least fix this particular link please :D

@geoffreymcgill geoffreymcgill self-assigned this Aug 4, 2021
@geoffreymcgill
Copy link
Collaborator

geoffreymcgill commented Aug 4, 2021

Thanks for pointing out the broken link. In v1.8.0, the link resolution process was refined, but it would appear this scenario where a relative link to a folder (../components/) requires additional attention. We might have made the wrong decision on how that type of link should be resolved.

We are discussing right now and coming up with a plan. If a patch release is required, we can implement the fix and make a new release quickly.

I will keep this thread up to date.

Thanks again for letting us know about this issue.

UPDATE: The broken ../components links in the docs have been fixed, but from my perspective, Retype should have correctly resolved those links. We are still discussing how Retype should handle this scenario.

@geoffreymcgill
Copy link
Collaborator

We are in the process of improving the logic Retype uses to resolve links. Once complete, the original scenario will be resolved correctly.

The plan is to include this bug fix (or is it an enhancement? 🤷) in a v1.8.1 patch release. With some luck, the patch will be released tomorrow. If not, it will be very soon thereafter. As soon as we have this fix in place and well tested, we will be releasing v1.8.1.

@geoffreymcgill geoffreymcgill added the bug Something isn't working label Aug 5, 2021
@geoffreymcgill geoffreymcgill added this to the v1.8.1 milestone Aug 5, 2021
@geoffreymcgill
Copy link
Collaborator

This issue has been fixed and the fix was included in v1.8.1, which has now been released.

Hope this helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants