Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parsing compound cron expression fields #115

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Conversation

reugn
Copy link
Owner

@reugn reugn commented Mar 6, 2024

No description provided.

@reugn reugn linked an issue Mar 6, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 73.40426% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 87.89%. Comparing base (8a940a4) to head (b3071f7).

Files Patch % Lines
quartz/cron.go 64.51% 14 Missing and 8 partials ⚠️
quartz/util.go 90.62% 2 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #115      +/-   ##
==========================================
- Coverage   89.67%   87.89%   -1.78%     
==========================================
  Files          19       19              
  Lines         920      950      +30     
==========================================
+ Hits          825      835      +10     
- Misses         67       77      +10     
- Partials       28       38      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reugn reugn merged commit 51879fa into master Mar 6, 2024
5 checks passed
@reugn reugn deleted the cron-compound-fields branch March 6, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some cron-expression will fail to be parsed.
2 participants