Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return error on NextFireTime for expired cron expression #70

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

reugn
Copy link
Owner

@reugn reugn commented Oct 6, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2023

Codecov Report

Merging #70 (2637df4) into master (1fb8849) will decrease coverage by 0.26%.
The diff coverage is 28.57%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
- Coverage   90.72%   90.46%   -0.26%     
==========================================
  Files          10       10              
  Lines         625      629       +4     
==========================================
+ Hits          567      569       +2     
- Misses         38       40       +2     
  Partials       20       20              
Files Coverage Δ
quartz/scheduler.go 90.00% <0.00%> (-0.96%) ⬇️
quartz/cron.go 78.47% <33.33%> (+0.30%) ⬆️

@reugn reugn merged commit cdb58bc into master Oct 6, 2023
5 checks passed
@reugn reugn deleted the expired-cron-expression branch October 6, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants