Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: module package structure #87

Merged
merged 1 commit into from
Jan 5, 2024
Merged

refactor!: module package structure #87

merged 1 commit into from
Jan 5, 2024

Conversation

reugn
Copy link
Owner

@reugn reugn commented Jan 5, 2024

  • Extract the internal and logger packages.
  • Create a job package containing implementations of the quartz.Job interface.

@codecov-commenter
Copy link

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (49ce1d9) 85.64% compared to head (4c271ff) 83.80%.

Files Patch % Lines
job/shell_job.go 84.61% 7 Missing and 1 partial ⚠️
job/curl_job.go 86.36% 6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
- Coverage   85.64%   83.80%   -1.85%     
==========================================
  Files          12       14       +2     
  Lines         815      815              
==========================================
- Hits          698      683      -15     
- Misses         82       97      +15     
  Partials       35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reugn reugn merged commit 5b8e094 into master Jan 5, 2024
5 checks passed
@reugn reugn deleted the package-restructure branch January 5, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants