Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hugo v0.60.0 (compatibility with goldmark) #26

Closed
reuixiy opened this issue Nov 27, 2019 · 3 comments
Closed

Hugo v0.60.0 (compatibility with goldmark) #26

reuixiy opened this issue Nov 27, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@reuixiy
Copy link
Owner

reuixiy commented Nov 27, 2019

Hugo v0.60.0 replaced the default Markdown renderer blackfriday with goldmark. I just tried v0.60.0 with goldmark and found some problems. These issues cannot be resolved at this time. I will fix them when Hugo releases a more stable version in the future...

@reuixiy reuixiy added the ATTENTION Something you should pay attention to label Nov 27, 2019
@reuixiy reuixiy pinned this issue Nov 27, 2019
@reuixiy
Copy link
Owner Author

reuixiy commented Nov 27, 2019

If you have installed the latest version of Hugo, please add the following code to your config.toml file to use the old blackfriday instead of the new goldmark...

[markup]
    defaultMarkdownHandler = "blackfriday"

More info https://gohugo.io/getting-started/configuration-markup/

reuixiy added a commit that referenced this issue Nov 29, 2019
@reuixiy reuixiy changed the title v0.60.0 v0.60.0 (compatibility with goldmark) Nov 30, 2019
@reuixiy reuixiy added enhancement New feature or request and removed ATTENTION Something you should pay attention to labels Nov 30, 2019
@theflyingfool
Copy link

I'm using a test box:

hugo version
Hugo Static Site Generator v0.61.0/extended linux/amd64 BuildDate: unknown

hugo server -D --disableFastRender

When I look at the output in chrome at localhost:1313 I'm not noticing anything strange. Could you please eleberate as to what it is doing

Granted it could have to do with having the following in my config.toml:


# Markdown rendering engine
[blackfriday]
  # Enable smart punctuation substitutions?
  smartypants = true
  # Open external links in a new window or tab?
  hrefTargetBlank = true
  # Disable some Blackfriday's Markdown extensions
  extensionsmask = ["hardLineBreak", "backslashLineBreak"]

I have not added the workaround listed above to my config file yet

Was not able to copy and paste anything there may be typo's above

@reuixiy
Copy link
Owner Author

reuixiy commented Dec 16, 2019

I see... It’s okay to use new default Markdown renderer goldmark if you have not encountered any strange changes. I recommend using old blackfriday because there are currently some issues* related to goldmark. But since you have not encountered any strange changes, just use the brand new goldmark!

  1. https://github.com/gohugoio/hugo/issues?utf8=%E2%9C%93&q=goldmark
  2. https://github.com/gohugoio/hugo/issues?q=is%3Aissue+is%3Aopen+label%3AMarkdown
  3. https://discourse.gohugo.io/search?q=goldmark

@reuixiy reuixiy changed the title v0.60.0 (compatibility with goldmark) Hugo v0.60.0 (compatibility with goldmark) Jan 8, 2020
@reuixiy reuixiy closed this as completed in 8c3cb2b Jan 8, 2020
@reuixiy reuixiy unpinned this issue Jan 8, 2020
ulmefors pushed a commit to ulmefors/hugo-theme-meme that referenced this issue Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants