Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support go modules (go.mod) instead of dep #177

Closed
ptman opened this issue Jul 23, 2019 · 4 comments
Closed

Support go modules (go.mod) instead of dep #177

ptman opened this issue Jul 23, 2019 · 4 comments
Assignees
Milestone

Comments

@ptman
Copy link
Contributor

ptman commented Jul 23, 2019

I hope this is the right place for this ticket

@eparziale
Copy link

@notzippy
Are there any plans to update revel cmd to support projects that use go modules instead of dep?

My team has used revel for the past year and has been very happy with the framework.

Until recently, we didn't need a proper dependency management tool like dep or go modules. (Instead we just maintained a list of required packages, and ran go get to fetch HEAD of each package)

However, we're now at a point where certain upstream dependency projects are forcing us to move to a dependency management tool. We could migrate to dep, but go modules seems like the direction that the go ecosystem is moving.

How much effort would be required to update revel cmd tool to support go modules?

FYI - I tried creating a basic revel application using go modules, but it failed to work

For reference - Here's a link to that sample barebones revel skeleton project that works when NOT using go-modules, but breaks when tweaked to use go modules:

Link to Working Revel skeleton App repo: https://github.com/ejparz/revel-example
**Healthy CircleCi start of app: ** https://circleci.com/gh/ejparz/revel-example/5

Small pull request on the same repo, adjusting the app to use go modules: https://github.com/ejparz/revel-example/pull/1/files

Corresponding failed CircleCi Build (Build fails because revel cmd is incompatible with go modules): https://circleci.com/gh/ejparz/revel-example/6


**If there are no plans to update revel to support go modules soon, then we'll adjust our build process to use dep instead :( **

@ptman
Copy link
Contributor Author

ptman commented Aug 31, 2019

We are using dep. I don't think revel will work with go modules currently. But @notzippy is working on go modules support and go modules can migrate from dep.

@eparziale
Copy link

Understood. We'll use dep.

Thanks for the info!

@ptman
Copy link
Contributor Author

ptman commented Apr 14, 2020

#180

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants