Initial commit to go mod #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 14, 2020
Added processor object to code Verified compile errors appearing Signed-off-by: notzippy@gmail.com
…late the SourceInfo object the same as before
Added packagepathmap to the SourceInfo, this in turn allows the RevelCLI app command to pass the source paths directly to Revel directly Added default to build to be "target" of the current folder Renamed source processor
Removed go/build reference in clean
Ran through testing individually for vendored Revel applications
added 3 commits
April 26, 2020 23:00
remaps the go mod command to use the develop branch.
Modified to use fsnotify directlyUpdated travis to not use go deps
added 2 commits
April 29, 2020 17:05
Added a gomod-flags parameter which allows you to run go mod commands on the go.mod file before the build is performed. This allows for development environments.
Added verbose flag so we can see what is occurring, Removed checkout for revel, not needed anymore
added 2 commits
April 29, 2020 21:32
Closed
notzippy
force-pushed
the
go-mod
branch
2 times, most recently
from
7ac9f88 to
b089001
Compare
Modified GOPATH to not modify build with go.mod Updated go.mod to version 1.12 Updated harness to setup listener before killing process Updated notvendored flag to --no-vendor Updated command_config to ensure no-vendor can be build Added additional checks in source path lookup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP for upgrading the command line tool to use go modules by default
What is done
go.modfiles are created in the base of the package source code and can be found by the revel run commandgolang.org/x/tools/go/package.ToDo
The goal is to completely rewrite the
ProcessSourcefunction, and we will eventually drop the old implementation