[maven] Update from component to inject per jsr330 #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maven has deprecated component now.
When you say "now", what version of Maven do you mean? It also seems very weird that Maven would deprecate Component in favor of javax.inject.Inject instead of jakarta.inject.Inject. |
|
From Google ai
Component annotation: This annotation was used to configure injection of Plexus components by MavenPluginManager. You can use JSR 330 annotations or Parameter with default expressions instead.
.....
Also directly deprecated https://maven.apache.org/plugin-tools/maven-plugin-annotations/apidocs/deprecated-list.html
Or
https://codehaus-plexus.github.io/plexus-containers/plexus-component-metadata/
Plexus itself is pretty much all deprecated.
Any maven 3.6.3+ if not earlier. Majority of core maven plugins already had replaced it.
Since recent releases it's now flagged as such.
Sent from my Verizon, Samsung Galaxy smartphone
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Christopher Tubbs ***@***.***>
Sent: Friday, January 10, 2025 3:05:58 PM
To: revelc/formatter-maven-plugin ***@***.***>
Cc: Jeremy Landis ***@***.***>; Author ***@***.***>
Subject: Re: [revelc/formatter-maven-plugin] [maven] Update from component to inject per jsr330 (PR #949)
maven has deprecated component now.
When you say "now", what version of Maven do you mean? It also seems very weird that Maven would deprecate Component in favor of javax.inject.Inject instead of jakarta.inject.Inject.
—
Reply to this email directly, view it on GitHub<#949 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAHODIZXA5B4KP3UDP6WJIT2KAR2NAVCNFSM6AAAAABUPPFLBCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOBTHEZDGNZSGM>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Oh they are not on jakarta yet (namespace or otherewise). As far as the physical library they are still using the original javax copy from Google. I reported that a long time ago. They didn't care to upgrade the gav. So, they are directly on the one with missing Metadata. You can override that, but I think the configuration on this plugin makes exclusions and replacements more of a problem. The one listed here is their physical usage.
Sent from my Verizon, Samsung Galaxy smartphone
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Christopher Tubbs ***@***.***>
Sent: Friday, January 10, 2025 3:05:58 PM
To: revelc/formatter-maven-plugin ***@***.***>
Cc: Jeremy Landis ***@***.***>; Author ***@***.***>
Subject: Re: [revelc/formatter-maven-plugin] [maven] Update from component to inject per jsr330 (PR #949)
maven has deprecated component now.
When you say "now", what version of Maven do you mean? It also seems very weird that Maven would deprecate Component in favor of javax.inject.Inject instead of jakarta.inject.Inject.
—
Reply to this email directly, view it on GitHub<#949 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAHODIZXA5B4KP3UDP6WJIT2KAR2NAVCNFSM6AAAAABUPPFLBCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOBTHEZDGNZSGM>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
@ctubbsii FWIW maven fixed to use jakarta.inject 2.0.1 in maven 4. Of course we will have to continue support for maven 3. And there is a general understanding that plugins need to be separately supported. That said, they also have javax.inject sitting in maven 4 as well. So that goes to explain why they didn't use the correct one because it would be rather hard to do so. |
ctubbsii
approved these changes
Jan 16, 2025
Comment on lines
+131
to
+135
| <dependency> | ||
| <groupId>javax.inject</groupId> | ||
| <artifactId>javax.inject</artifactId> | ||
| <version>1</version> | ||
| </dependency> |
There was a problem hiding this comment.
It's unfortunate that javax didn't use a bom, like jakartaee does. I hate managing the javax dependency versions individually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maven has deprecated component now.