feat(action-options): add tool_name option for reviewdog reporter #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey reviewdog team! thanks for this awesome action!
I implemented it on a private project to take care of the javascript guidelines and I notice a use case that it's not supported at the time, as it is a little wired for small projects, but not that uncommon. The project is a rails 4.2 app with
Angular
and its transitioning fromES5
on the assets pipeline toES6
withwebpacker
. As a result there are 2 javascripts directories,app/assets/javascript
for old files or non-migrated files andapp/javascript
for the ES6-webpacker part of the project. For this reason, i had to had two steps on myreviewdog
check foreslint
:the problem is that as the action uses "eslint" as de name of the reporter for both checks, the first report is ignored and only the second one is used.
I managed to solve this by adding the
tool_name
option when the action executesreviewdog
(I stole the idea from yourreviewdog/action-rubocop
repo)Hope this PR is well recieved and become useful for someone else!