-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add directory argument #15
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC, github-pr-check doesn't work well with subdirectory run.
Can you confirm it works or consider to use golangci_lint_flags to specify sub dir?
Maybe we can improve the document too.
README.md
Outdated
@@ -87,6 +90,7 @@ jobs: | |||
# Can pass --config flag to change golangci-lint behavior and target | |||
# directory. | |||
golangci_lint_flags: "--config=.github/.golangci.yml ./testdata" | |||
directory: subdirectory/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you specify sub dir like this with golangci_lint_flags?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does not seem like it: https://github.com/ironPeakServices/iron-redis/pull/15/checks?check_run_id=331138356
Related issues: Is there any way we could add this feature without breaking the |
Here is the workaround I use: https://github.com/aslafy-z/action-golangci-lint/blob/master/entrypoint.sh#L9 |
ping @haya14busa |
As I said, github-pr-check won't work with subdir, so I cannot merge it at this point. bwt, is it really reproducible with latest reviewdog/golangci-lint binary? I cloned ironPeakServices/iron-redis and ran following command. It succeeded.
|
@haya14busa seems not with |
Can you try v1.1.6 (or v1)? |
any update on whether this will merge? |
We are also seeing this problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewdog can now support sub-dir run for every reporter.
https://github.com/reviewdog/reviewdog/blob/master/CHANGELOG.md#v0100---2020-05-07
LGTM other than nit comment.
🚀 [bumpr] Bumped! New version:v1.6.0 Changes:v1.5.0...v1.6.0 |
Hi, @hazcod! We merged your PR to reviewdog! 🐶 We just invited you to join the @reviewdog organization on GitHub. Thanks again! |
Makes it possible to run the action in a subdirectory.