Provide default Github token #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaurenceGA
added
documentation
|
Seems to have half worked... 😕 |
haya14busa
reviewed
May 11, 2020
|
🚀 [bumpr] Bumped! New version:v1.4.0 Changes:v1.3.1...v1.4.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw that this was possible in some other actions. Instead of making every single user always have
github_token: ${{ secrets.github_token }}, we can just provide this for them, while still allowing them to change it.Also, we don't have to put
${{ secrets.github_token }}, we can just put${{ github.token }}. They're equivalent.If this works and everyone thinks it's a good idea, I think we should have it in other reviewdog actions too.
Just makes people's workflows a tiny bit less noisy 🙂