Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base image change #51

Merged
merged 6 commits into from
Mar 27, 2024
Merged

base image change #51

merged 6 commits into from
Mar 27, 2024

Conversation

srz-zumix
Copy link
Contributor

@srz-zumix srz-zumix commented Mar 27, 2024

When building on a rootless docker self-hosted runner, reviewdog installation fails with wget: bad address 'github.com'.
This seems to be an issue with alpine image and appears after 3.13.
I think the minimum fix is to downgrade to alpine 3.12 or use a different OS image.

alpinelinux/docker-alpine#155

image result
node:16-alpine3.12 OK
node:18-alpine3.14 NG
node:20-alpine3.19 NG
node:18-bullseye-slim OK

@srz-zumix srz-zumix changed the title base image node:20-alpine3.19 base image change Mar 27, 2024
@srz-zumix srz-zumix marked this pull request as ready for review March 27, 2024 13:44
Copy link
Contributor

@shogo82148 shogo82148 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shogo82148 shogo82148 merged commit 49bb375 into master Mar 27, 2024
3 checks passed
@shogo82148 shogo82148 deleted the feature/update_base_image branch March 27, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants