Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remark-lint failures don't fail the build #2

Closed
asbjornu opened this issue Jun 28, 2020 · 4 comments · Fixed by #3 or #6
Closed

remark-lint failures don't fail the build #2

asbjornu opened this issue Jun 28, 2020 · 4 comments · Fixed by #3 or #6

Comments

@asbjornu
Copy link
Member

Either, remark-lint don't exit with a non-zero exit code on failures, or the exit code is not propagated to GitHub Actions. Either way, I have 82 failures in one of my builds and it's still marked as successful.

@prologic
Copy link
Contributor

Can you put a PR top fix this?

@asbjornu
Copy link
Member Author

asbjornu commented Jun 29, 2020

I would love to, @prologic. Do you have any ideas why the exit code of the action is 0 even though remark-lint fails? Is it reviewdog that masks the exit code somehow?

@prologic
Copy link
Contributor

prologic commented Jul 8, 2020

I would love to, @prologic. Do you have any ideas why the exit code of the action is 0 even though remark-lint fails? Is it reviewdog that masks the exit code somehow?

I don't know off the top of my head. I'd suspect its the underlying tool is returning a non-sense exit status. If that's the case; that should be fixed upstream; I doubt it would be reviewdog itself at fault here...

@asbjornu
Copy link
Member Author

@prologic, I believe I've fixed the problem in #3.

prologic added a commit that referenced this issue Dec 14, 2020
Fixes #2, adds github-pr-review support and updates the readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants