-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remark-lint failures don't fail the build #2
Comments
Can you put a PR top fix this? |
I would love to, @prologic. Do you have any ideas why the exit code of the action is |
I don't know off the top of my head. I'd suspect its the underlying tool is returning a non-sense exit status. If that's the case; that should be fixed upstream; I doubt it would be reviewdog itself at fault here... |
Fixes #2, adds github-pr-review support and updates the readme
Either,
remark-lint
don't exit with a non-zero exit code on failures, or the exit code is not propagated to GitHub Actions. Either way, I have 82 failures in one of my builds and it's still marked as successful.The text was updated successfully, but these errors were encountered: