Fix reviewdog exit code bug and error format syntax problem #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current errorformat was incorrect see #3. I fixed this by adding the right syntax to the reviewdog pre-defined error formats. This syntax can be found under the `remark-lint` tag.
|
This pull request is blocked by reviewdog/errorformat#79. |
|
The fix has been merged with the review dog main branch. We can close this pull request as soon as review dog v0.11.0 is available. |
This commit temporary switches to use the reviewdog nightly branch. We have to revert back to using the stable branch after v0.12.0 is released.
|
I pushed a fix to the reviewdog nightly branch reviewdog/nightly#6. |
|
The fix has been merged I opened a new pull request #5 to temporary switch to using the nightly branch until the new version has been released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in #3 the current GitHub actions don't seem to work. Apart from now throwing an error when a warning was generated by remark-lint it also specifies the wrong errorformat for reviewdog. As a result no error will be thrown and no warnings are displayed.