Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accepts different rules and presets #55

Merged

Conversation

thepabloaguilar
Copy link
Member

Hello @rickstaa, thanks for this GitHub actions!

I'm submitting this MR with a few modifications that will be helpful to use in other projects!

The first thing I added is a new input, rules_and_presets, that will handle additional presets/plugins! You may wondering why a new input if we can do that using a package.json. Well, in some cases we don't want to add additional files (package.json and package-lock.json) to our repositories that has a lot of other files, we just one to simply put all the things we need in a string! Also, as it's a linter plugin we don't want to set a version 'cause the latest should be fine and with rules_and_presets we can also set a version if needed!

The second thing, I changed remark_args to have --use=remark-preset-lint-recommended as a default value. It's better to give the users the ability to change that whenever they want.

Related wemake-services/wemake-python-styleguide#2215

Closes #54

@sobolevn
Copy link
Member

sobolevn commented Oct 10, 2021

Looks like I maintain this repo as well 😆
I was not aware of that!

I've approved the CI and kindly ask real maintainers to review this PR, because I am not familiar with the source code at all 🙂

@thepabloaguilar thepabloaguilar force-pushed the accepts-different-rules-and-presets branch from 812b301 to 0d1bb11 Compare October 10, 2021 22:22
@thepabloaguilar
Copy link
Member Author

You're everywhere @sobolevn 😆

Please, approve the workflow to run again!

@rickstaa rickstaa self-requested a review October 11, 2021 16:34
@rickstaa rickstaa mentioned this pull request Oct 11, 2021
@rickstaa
Copy link
Member

@thepabloaguilar Thanks a lot for your pull request! Overall, your pull request looks good. I will perform some tests later this week.

@thepabloaguilar
Copy link
Member Author

Thanks, @rickstaa!!

entrypoint.sh Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
@rickstaa
Copy link
Member

rickstaa commented Oct 18, 2021

@thepabloaguilar @sobolevn I applied the changes we discussed above and requested a review from @asbjornu. I will open an issue to translate this action to a composite action after #55 has been merged.

@rickstaa rickstaa requested a review from asbjornu October 18, 2021 07:33
@rickstaa rickstaa added the bump:minor Bump the minor version on pull request label Oct 18, 2021
@rickstaa rickstaa force-pushed the accepts-different-rules-and-presets branch 2 times, most recently from 4fde86e to 9bcad63 Compare October 18, 2021 15:17
@rickstaa rickstaa self-requested a review October 18, 2021 15:20
entrypoint.sh Outdated Show resolved Hide resolved
action.yml Show resolved Hide resolved
entrypoint.sh Show resolved Hide resolved
@rickstaa
Copy link
Member

@asbjornu I pushed the changes you requested. I think now the logic is correct.

@rickstaa rickstaa force-pushed the accepts-different-rules-and-presets branch 2 times, most recently from 9f34aef to 039da70 Compare October 21, 2021 09:29
entrypoint.sh Show resolved Hide resolved
This commit removes the 'rules_and_presets' argument and changes the
'remark_args' default value.
@rickstaa rickstaa force-pushed the accepts-different-rules-and-presets branch from 039da70 to f31f35b Compare October 21, 2021 10:15
@rickstaa rickstaa merged commit 167d59b into reviewdog:main Oct 21, 2021
@review-dog
Copy link
Member

Hi, @thepabloaguilar! We merged your PR to reviewdog! 🐶
Thank you for your contribution! ✨

We just invited you to join the @reviewdog organization on GitHub.
Accept the invite by visiting https://github.com/orgs/reviewdog/invitation.
By joining the team, you'll be a part of reviewdog community and can help the maintainance of reviewdog.

Thanks again!

@github-actions
Copy link
Contributor

🚀 [bumpr] Bumped! New version:v4.1.0 Changes:v4.0.0...v4.1.0

@thepabloaguilar thepabloaguilar deleted the accepts-different-rules-and-presets branch October 21, 2021 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump:minor Bump the minor version on pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Customizing presets
5 participants