-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accepts different rules and presets #55
Accepts different rules and presets #55
Conversation
Looks like I maintain this repo as well 😆 I've approved the CI and kindly ask real maintainers to review this PR, because I am not familiar with the source code at all 🙂 |
…s through action input
812b301
to
0d1bb11
Compare
You're everywhere @sobolevn 😆 Please, approve the workflow to run again! |
@thepabloaguilar Thanks a lot for your pull request! Overall, your pull request looks good. I will perform some tests later this week. |
Thanks, @rickstaa!! |
@thepabloaguilar @sobolevn I applied the changes we discussed above and requested a review from @asbjornu. I will open an issue to translate this action to a composite action after #55 has been merged. |
4fde86e
to
9bcad63
Compare
@asbjornu I pushed the changes you requested. I think now the logic is correct. |
9f34aef
to
039da70
Compare
This commit removes the 'rules_and_presets' argument and changes the 'remark_args' default value.
039da70
to
f31f35b
Compare
Hi, @thepabloaguilar! We merged your PR to reviewdog! 🐶 We just invited you to join the @reviewdog organization on GitHub. Thanks again! |
🚀 [bumpr] Bumped! New version:v4.1.0 Changes:v4.0.0...v4.1.0 |
Hello @rickstaa, thanks for this GitHub actions!
I'm submitting this MR with a few modifications that will be helpful to use in other projects!
The first thing I added is a new input,
rules_and_presets
, that will handle additional presets/plugins! You may wondering why a new input if we can do that using apackage.json
. Well, in some cases we don't want to add additional files (package.json
andpackage-lock.json
) to our repositories that has a lot of other files, we just one to simply put all the things we need in a string! Also, as it's a linter plugin we don't want to set a version 'cause the latest should be fine and withrules_and_presets
we can also set a version if needed!The second thing, I changed
remark_args
to have--use=remark-preset-lint-recommended
as a default value. It's better to give the users the ability to change that whenever they want.Related wemake-services/wemake-python-styleguide#2215
Closes #54