Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make github_token optional #61

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

asbjornu
Copy link
Member

Make github_token optional. Resolves #60.

@rickstaa
Copy link
Member

@asbjornu Thanks for spotting this. Feel free to merge it under the major, minor or patch labels.

@rickstaa
Copy link
Member

I prefer the bump:minor label since it is a significant change but does not break things.

@asbjornu
Copy link
Member Author

asbjornu commented Nov 30, 2021

I prefer the bump:minor label since it is a significant change but does not break things.

I agree, but I'm not certain I understand what you mean by "label". As in conventional commits or by manually creating a v5.1.0 tag in Git?

@rickstaa rickstaa added the bump:minor Bump the minor version on pull request label Nov 30, 2021
@rickstaa
Copy link
Member

Ah sorry for being so unclear, it was related to the git label used by the release action. This will create the tag automatically when the pull request is merged.

@rickstaa rickstaa merged commit f493d99 into reviewdog:main Nov 30, 2021
@github-actions
Copy link
Contributor

🚀 [bumpr] Bumped! New version:v5.1.0 Changes:v5.0.2...v5.1.0

@rickstaa
Copy link
Member

@asbjornu asbjornu deleted the feature/optional_github_token branch November 30, 2021 12:56
@asbjornu
Copy link
Member Author

Ah, right. Thanks, @rickstaa! 🙏🏼

asbjornu added a commit that referenced this pull request Nov 30, 2021
Update documentation for `github_token` now that #61 is merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump:minor Bump the minor version on pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

github_token should be made an optional property
2 participants