Introduce LoadingStrategy for Dod #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yatsinar
previously approved these changes
Nov 23, 2023
iismagilov
reviewed
Nov 23, 2023
dod/src/main/java/com/revolut/rxdata/dod/DataObservableDelegate.kt
Outdated
Show resolved
Hide resolved
iismagilov
reviewed
Nov 23, 2023
artyomychsvc
force-pushed
the
dod_loading_strategy
branch
from
4b05b20 to
2d361d4
Compare
iismagilov
approved these changes
Nov 24, 2023
yatsinar
previously approved these changes
Nov 24, 2023
yatsinar
previously approved these changes
Nov 24, 2023
artyomychsvc
force-pushed
the
dod_loading_strategy
branch
from
5358ee2 to
cd1dcaf
Compare
iismagilov
approved these changes
Nov 24, 2023
yatsinar
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to be able to load the data in some cases from the cache only if it exists(memory or storage) without net requests.
The exact case: User opens the screen with some hidden but prefetched(if exists in the storage cache) data. To improve ux and don't make unneeded net api calls. The patch allows us to control net request count on startup.