Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix completely broken ESP8266 miner (ver. 3.33) #1586

Merged
merged 1 commit into from
Dec 3, 2022

Conversation

Chupaka
Copy link
Contributor

@Chupaka Chupaka commented Dec 3, 2022

And save last job difficulty for future use in dashboard

And save last job difficulty for future use in dashboard
@revoxhere
Copy link
Owner

Can you provide more details?

@revoxhere revoxhere self-assigned this Dec 3, 2022
@Chupaka
Copy link
Contributor Author

Chupaka commented Dec 3, 2022

b54d33b this patch introduced MiningJob struct, and job parsing functionality was mainly moved there. But unsigned int difficulty = 0; global var is still here (not updated anymore), so for (unsigned int duco_numeric_result = 0; duco_numeric_result < difficulty; duco_numeric_result++) { never enters the loop body (as difficulty is now always zero). So, fixing that by using correct job.difficulty. But we can't remove difficulty var because it's used by web dashboard - so I still save last job parsing result to this var.

@revoxhere revoxhere merged commit e3df560 into revoxhere:master Dec 3, 2022
@Chupaka Chupaka deleted the patch-1 branch December 3, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants