Merge pull request #210 from AbrJA/master

Bug fix for killing child processes when background = TRUE
rexyai · Apr 14, 2024 · 71feba8 · 71feba8
2 parents 04fd819 + a8bf1ef
commit 71feba8
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/R/BackendRserve.R b/R/BackendRserve.R
@@ -330,7 +330,7 @@ BackendRserve = R6::R6Class(
 #' @title Creates ApplicationProcess object
 #'
 #' @description
-#' Creates ApplicationProcess to hold PID of the runnung applicaiton.
+#' Creates ApplicationProcess to hold PID of the running application.
 #'
 ApplicationProcess = R6::R6Class(
   classname = "ApplicationProcess",
@@ -345,12 +345,12 @@ ApplicationProcess = R6::R6Class(
     },
     #' @description
     #' Send signal to process.
-    #' @param signal Singal code.
+    #' @param signal Signal code.
     kill = function(signal = 15L) {
-      # kill service
-      tools::pskill(self$pid, signal)
-      # kill childs
-      system(sprintf("pkill -%s -P %s", signal, self$pid), wait = FALSE)
+      # get childs
+      child_pids <- suppressWarnings(system(sprintf("pgrep -P %s", self$pid), intern = TRUE))
+      # kill all
+      tools::pskill(c(self$pid, child_pids), signal)
     }
   )
 )