Add horizontal scrolling support to scrollview #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the recovery logic to a separate function so users of the library may call it *without* using the default panic handler. Reference: rockorager#146
It should be pretty safe to assume that posix.empty_sigset is supported on most, if not all, posix systems. Individual OSes that need a different default value may add a case to the switch like macos. This should open up support for most other posix systems. closes rockorager#151
Some improvements to WindowsTty. The init function will now catch and propagate an error.InvalidHandle so that caller can catch/handle it. In addition, I added packed structs for the input/output console modes which makes it convenient to manage the bits and is what zigwin32 generates for its bindings. I also made these newly added types and wrapper functions public as they can be generally useful for terminal applications.
`\x0A` was being parsed as an enter keypress. Distinguish this explicitly as a ctrl+j press.
vaxis-aio reuses the handleEventGeneric function
Still a work in progress. At this point it's essentially just the ListView widgets with some extermely minor tweaks.
The order of operations originally used resulted in the wrong height due to truncation in integer division.
reykjalin
force-pushed
the
add/horizontal-scrolling-support-to-scrollview
branch
from
0d88808 to
0c341b3
Compare
|
Closed in favor of rockorager#157 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary PR to make the changes clearer until rockorager#148 is accepted.