Skip to content

Commit

Permalink
Merge pull request Expensify#36242 from esh-g/tooltip-create
Browse files Browse the repository at this point in the history
Change the global create and DM create tooltips to read Create
  • Loading branch information
youssef-lr authored Feb 16, 2024
2 parents 758e056 + 4122e53 commit 07ba613
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion src/components/FloatingActionButton.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ function FloatingActionButton({onPress, isActive, accessibilityLabel, role}: Flo
};

return (
<Tooltip text={translate('common.new')}>
<Tooltip text={translate('common.create')}>
<PressableWithoutFeedback
style={styles.h100}
accessibilityLabel={accessibilityLabel}
Expand Down
2 changes: 1 addition & 1 deletion src/languages/en.ts
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ export default {
next: 'Next',
previous: 'Previous',
goBack: 'Go back',
create: 'Create',
add: 'Add',
resend: 'Resend',
save: 'Save',
Expand Down Expand Up @@ -425,7 +426,6 @@ export default {
oneMoment: "One moment while we redirect you to your company's single sign-on portal.",
},
reportActionCompose: {
addAction: 'Actions',
dropToUpload: 'Drop to upload',
sendAttachment: 'Send attachment',
addAttachment: 'Add attachment',
Expand Down
2 changes: 1 addition & 1 deletion src/languages/es.ts
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ export default {
searchWithThreeDots: 'Buscar...',
select: 'Seleccionar',
next: 'Siguiente',
create: 'Crear',
previous: 'Anterior',
goBack: 'Volver',
add: 'Añadir',
Expand Down Expand Up @@ -416,7 +417,6 @@ export default {
oneMoment: 'Un momento mientras te redirigimos al portal de inicio de sesión único de tu empresa.',
},
reportActionCompose: {
addAction: 'Acción',
dropToUpload: 'Suelta el archivo aquí para compartirlo',
sendAttachment: 'Enviar adjunto',
addAttachment: 'Añadir archivo adjunto',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ function AttachmentPickerWithMenuItems({
</PressableWithFeedback>
</Tooltip>
)}
<Tooltip text={translate('reportActionCompose.addAction')}>
<Tooltip text={translate('common.create')}>
<PressableWithFeedback
ref={actionButtonRef}
onPress={(e) => {
Expand All @@ -293,7 +293,7 @@ function AttachmentPickerWithMenuItems({
style={styles.composerSizeButton}
disabled={isBlockedFromConcierge || disabled}
role={CONST.ROLE.BUTTON}
accessibilityLabel={translate('reportActionCompose.addAction')}
accessibilityLabel={translate('common.create')}
>
<Icon
fill={theme.icon}
Expand Down
2 changes: 1 addition & 1 deletion tests/perf-test/ReportActionCompose.perf-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ test('[ReportActionCompose] should render Composer with text input interactions'
test('[ReportActionCompose] should press add attachemnt button', async () => {
const scenario = async () => {
// Query for the attachment button
const hintAttachmentButtonText = Localize.translateLocal('reportActionCompose.addAction');
const hintAttachmentButtonText = Localize.translateLocal('common.create');
const attachmentButton = await screen.findByLabelText(hintAttachmentButtonText);

fireEvent.press(attachmentButton, mockEvent);
Expand Down

0 comments on commit 07ba613

Please sign in to comment.