Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sleep(10) #74

Closed
hakavlad opened this issue Jul 6, 2018 · 3 comments
Closed

Sleep(10) #74

hakavlad opened this issue Jul 6, 2018 · 3 comments

Comments

@hakavlad
Copy link
Contributor

hakavlad commented Jul 6, 2018 •
edited
Loading

Closed too early. The discussion should be continued.

Firstly, sleep(10) not declared and users are not warned.

Secondly, sleep(10) is too long, sleep(3) is enough.
@rfjakob
Copy link
Owner

rfjakob commented Jul 6, 2018

It is decleared here

earlyoom/kill.c

Line 226 in 124239d

fprintf(stderr, "Sleeping 10 seconds\n");
, but 3 seconds should be enough, I agree.

rfjakob added a commit that referenced this issue Jul 6, 2018
@rfjakob
userspace_kill: only sleep 1 second on failure
c588216 
10 seconds may be too long, and 1 message / sec is
okay in terms of log spam.

I decided to NOT use a #define for the value, because
then several literal strings would have to be replaced
with snprintf. Not worth it.

#74
@rfjakob
Copy link
Owner

rfjakob commented Jul 6, 2018

I went for one second. Good enough to limit log spam.

@hakavlad
Copy link
Contributor Author

hakavlad commented Jul 6, 2018 •
edited
Loading

It is decleared here

Users don't read code. It is not in docs.

Users don't warned that earlyoom may sleep(10) before earlyoom started.

@rfjakob rfjakob closed this as completed in bd81b26 Jul 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rfjakob @hakavlad