Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for fallocate #1

Closed
rfjakob opened this issue Oct 4, 2015 · 0 comments
Closed

Add support for fallocate #1

rfjakob opened this issue Oct 4, 2015 · 0 comments
Labels
feature request help wanted

Comments

@rfjakob
Copy link
Owner

rfjakob commented Oct 4, 2015 •
edited
Loading

We do not support fallocate(2) at the moment (neither does EncFS).

However, we do return the proper ENOSYS value so applications can automatically fall back to another allocation method.

This bug keeps track of the efforts to implement fallocate. If you are interested, the implementation will look a lot like Truncate() in [file.go](https://github.com/rfjakob/gocryptfs/blob/master/internal/fusefrontend/file.go!
rfjakob added a commit that referenced this issue Oct 4, 2015
@rfjakob
tests: add TestFileHoles
fa88741 
Create a file with holes by writing to offset 0 (block #0) and
offset 4096 (block #1).

This test currently fails.
rfjakob added a commit that referenced this issue Oct 4, 2015
@rfjakob
fallocate: return ENOSYS
c7313f3 
The implementation was incomplete, disable fallocate completely for now.
See #1

Fixes xfstests generic/075
@rfjakob rfjakob mentioned this issue Jan 4, 2016
Closed
@rfjakob rfjakob closed this as completed in 54470ba Jul 2, 2016
rfjakob added a commit that referenced this issue Sep 3, 2017
@rfjakob
performance.txt: update for v1.4.1 latest commits, and kernel update
a710451 
$ uname -a
Linux brikett 4.12.5-300.fc26.x86_64 #1 SMP Mon Aug 7 15:27:25 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
rfjakob added a commit that referenced this issue Jan 25, 2018
@rfjakob
syscallcompat: fix reversed warning output
b318572 
We used to print somewhat strange messages:

	Getdents: corrupt entry #1: Reclen=276 > 280. Returning EBADR

Reported at #197
@salvadorsosa salvadorsosa mentioned this issue Feb 8, 2018
Closed
@lechner lechner mentioned this issue Aug 28, 2018
Closed
@simpz simpz mentioned this issue Oct 11, 2018
Closed
rfjakob added a commit that referenced this issue Nov 4, 2018
@rfjakob
fusefrontend: make OpenDir() symlink-safe
b205136 
Interestingly, little or no performance impact:

$ ./benchmark.bash
Testing gocryptfs at /tmp/benchmark.bash.39W: gocryptfs v1.6-42-g30c2349-dirty; go-fuse v20170619-66-g6df8ddc; 2018-11-04 go1.11
Downloading linux-3.0.tar.gz
/tmp/linux-3.0.tar.gz                  100%[=========================================================================>]  92.20M  2.93MB/s    in 31s
2018-11-04 21:44:44 URL:https://cdn.kernel.org/pub/linux/kernel/v3.0/linux-3.0.tar.gz [96675825/96675825] -> "/tmp/linux-3.0.tar.gz" [1]
WRITE: 262144000 bytes (262 MB, 250 MiB) copied, 1.1808 s, 222 MB/s
READ:  262144000 bytes (262 MB, 250 MiB) copied, 0.866438 s, 303 MB/s
UNTAR: 24.745
MD5:   12.050
LS:    3.525
RM:    9.544

Note: kernel has been updated:

$ uname -a
Linux brikett 4.18.16-200.fc28.x86_64 #1 SMP Sat Oct 20 23:53:47 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
rfjakob added a commit that referenced this issue Nov 11, 2018
@rfjakob
fusefrontend: make OpenDir() symlink-safe
c798131 
Interestingly, little or no performance impact:

$ ./benchmark.bash
Testing gocryptfs at /tmp/benchmark.bash.39W: gocryptfs v1.6-42-g30c2349-dirty; go-fuse v20170619-66-g6df8ddc; 2018-11-04 go1.11
Downloading linux-3.0.tar.gz
/tmp/linux-3.0.tar.gz                  100%[=========================================================================>]  92.20M  2.93MB/s    in 31s
2018-11-04 21:44:44 URL:https://cdn.kernel.org/pub/linux/kernel/v3.0/linux-3.0.tar.gz [96675825/96675825] -> "/tmp/linux-3.0.tar.gz" [1]
WRITE: 262144000 bytes (262 MB, 250 MiB) copied, 1.1808 s, 222 MB/s
READ:  262144000 bytes (262 MB, 250 MiB) copied, 0.866438 s, 303 MB/s
UNTAR: 24.745
MD5:   12.050
LS:    3.525
RM:    9.544

Note: kernel has been updated:

$ uname -a
Linux brikett 4.18.16-200.fc28.x86_64 #1 SMP Sat Oct 20 23:53:47 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
rfjakob added a commit that referenced this issue Jan 1, 2019
@rfjakob
fusefrontend: make OpenDir() symlink-safe
21f1f85 
Interestingly, little or no performance impact:

$ ./benchmark.bash
Testing gocryptfs at /tmp/benchmark.bash.39W: gocryptfs v1.6-42-g30c2349-dirty; go-fuse v20170619-66-g6df8ddc; 2018-11-04 go1.11
Downloading linux-3.0.tar.gz
/tmp/linux-3.0.tar.gz                  100%[=========================================================================>]  92.20M  2.93MB/s    in 31s
2018-11-04 21:44:44 URL:https://cdn.kernel.org/pub/linux/kernel/v3.0/linux-3.0.tar.gz [96675825/96675825] -> "/tmp/linux-3.0.tar.gz" [1]
WRITE: 262144000 bytes (262 MB, 250 MiB) copied, 1.1808 s, 222 MB/s
READ:  262144000 bytes (262 MB, 250 MiB) copied, 0.866438 s, 303 MB/s
UNTAR: 24.745
MD5:   12.050
LS:    3.525
RM:    9.544

Note: kernel has been updated:

$ uname -a
Linux brikett 4.18.16-200.fc28.x86_64 #1 SMP Sat Oct 20 23:53:47 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
rfjakob added a commit that referenced this issue Oct 17, 2020
@rfjakob
syscallcompat: add getxattr fastpaths
c943ed3 
The allocations from Lgetxattr were #1 in the tar extract
allocation profile (caused by security.capability lookups).
No more!

$ benchstat old.txt new.txt
name         old time/op  new time/op  delta
Lgetxattr-4  15.2µs ± 0%   1.8µs ± 0%   ~     (p=1.000 n=1+1)

$ ./benchmark.bash
Testing gocryptfs at /tmp/benchmark.bash.H8p: gocryptfs v2.0-beta1-4-g95ea738-dirty; go-fuse v2.0.4-0.20200908172753-0b6cbc515082 => github.com/rfjakob/go-fuse/v2 v2.0.4-0.20201015204057-88b12c99f8af; 2020-10-18 go1.15.3 linux/amd64
/tmp/benchmark.bash.H8p.mnt is a mountpoint
WRITE: 262144000 bytes (262 MB, 250 MiB) copied, 0,520109 s, 504 MB/s
READ:  262144000 bytes (262 MB, 250 MiB) copied, 0,255672 s, 1,0 GB/s
UNTAR: 30,238
MD5:   12,721
LS:    10,038
RM:    16,536
@Leon-001 Leon-001 mentioned this issue Jan 14, 2024
Closed
@ccchan234 ccchan234 mentioned this issue Feb 11, 2024
Closed
@noe-noenoe noe-noenoe mentioned this issue Mar 13, 2024
Closed
@glhughes123 glhughes123 mentioned this issue Jan 17, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rfjakob