-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrupt files and folder when gocryptfs cipherdir is synchronised via Syncthing #549
Comments
I have reached the same issue. I have 3 devices (server, PC and android) and I am syncing every device with all the others. I do not see "corrupt entry errors" but I have |
Because of this I have moved to https://cryptomator.org/ for now. It seems to work well with syncthing so far. I would prefer gocryptfs because it has fully open-sourced android app, but until this issue is solved, it is not possible. |
I see three different issues here:
Looks like syncthing forgot to copy the
The file names in the folder do not match the
Syncthing created a file |
I will double-check the previous points, but can say now that gocryptfs-encrypted folder is already in a subfolder of the folder synced. Please let me know if there is anything else that might help you to debug this. |
@savchenko i only saw the .stlfolder in the messages from @peterflock |
@savchenko Do you see the same corruption on all synchronised copies or does it look different? |
Question to all syncthing users here: Do you use the I started syncthing three times like this
and synced a folder between all three, so that I have three copies on disk, and mounted the three copies three times (without using `-sharedstorage). And after some trying I did manage to reprodruce git corruption:
|
Todos for go-fuse to make things more robust even without
|
Different. Here is an output from another endpoint, same repository I've mentioned in the first post:
|
Thanks! The |
Similar? problem here. I'm also using syncthing and I realized I can't open the directory with my password anymore. it says Altho I did not have the sharedstorage flag, I didn't know it existed :( I don't think there was concurrent access tho, at least not concurrent writes to the same file |
@tleydxdy you get this?
Decrypting the master key only depends on Keyboard layout problem maybe? |
Change was merged: hanwen/go-fuse@a90e1f4 Done using: $ go mod edit -dropreplace github.com/hanwen/go-fuse/v2 $ go get github.com/hanwen/go-fuse/v2@master go: downloading github.com/hanwen/go-fuse/v2 v2.1.1-0.20210423170155-a90e1f463c3f go get: upgraded github.com/hanwen/go-fuse/v2 v2.0.4-0.20210125162859-8e0bbdb16cb7 => v2.1.1-0.20210423170155-a90e1f463c3f Related: #549
|
Dear syncthing users, can you see if you can still trigger this problem with v2.0-beta3 ? This has the "track most recent parent" improvement (see changelog) Download from https://github.com/rfjakob/gocryptfs/releases/tag/v2.0-beta3 |
gocryptfs v2.0 is out some time now containing the improvements. I tested some time ago with syncthing and was unable to cause problems. Even without -sharedstorage this should not happen anymore. Unless somebody notices otherwise I'll call this fixed. |
I have started observing this during the last 2 weeks or so, albeit on a smaller scale.
In previous cases corruption was mostly affecting
git
indexes, but here damage is more extensive:Folder that shows
5=input/output error
is displayed in clear-text as empty.Is there anything I can do to help with investigating this issue? Or maybe there is some underlying incompatibility of GoCrypt share being synchronised bi-directionally?
Thanks.
The text was updated successfully, but these errors were encountered: