-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to suppress masterkey printing. #76
Comments
Do you know "-q" ? |
I didn't; rtfm failure. I like the other info messages, but -q works for this issue. It still concerns me that the default is to print the master key each time--users might not be careful about where they unlock their mounts, but I can accept if this is the design direction you want to stick with. |
The concern that the master key may end up in too many terminal buffers is certainly valid, especially if the user has already saved it somewhere. I think I'll add " PS: I'm amazed you discovered that the master key is not printed when writing to a pipe :) |
I think that the idea of printing the master key (when the user didn't ask for that) is a very bad idea. It shouldn't be suppressed by an option, it should be not printed without a special option. |
It is no longer printed at all when mounting a filesystem, printing on -init can be disabled with -q. #76
It is no longer printed at all when mounting a filesystem, printing on -init can be disabled with -q. #76
Fixed by 6d64dfe . Master key is now only printed on init. |
Some of the documentation (the git README.md, and the home page), still says "keep a copy of your master key (printed on mount) in a safe place." Is there a command option to print out your master key? If you use a gui like SiriKali to create a volume, you will not see the master key on init. I may be overlooking it but now I do not see a way to print out the master key after init. Thanks. |
It's not in gocryptfs itself but in gocryptfs-xray, option -dumpmasterkey ( https://github.com/rfjakob/gocryptfs/blob/master/Documentation/MANPAGE-XRAY.md ) I will fix the docs, thanks for the notice |
Oh great, I did not know about gocryptfs-xray. Thank you! |
The terminal on a remote system does not need to know the master key every time, especially if the user has already stored it.
Currently, the masterkey will not print if logging to a file, so to work around the missing flag, I currently do the following:
gocryptfs .gocrypt-store gocrypt |tee /dev/null
Please add a mount option or short flag to suppress the master key output, or perhaps change the default behavior to only print the master key on init.
gocryptfs v1.2-35-g0f40afc; go-fuse 0ad840c; 2017-02-06 go1.7.4
The text was updated successfully, but these errors were encountered: