Even more syscallcompat improvements #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For absolute paths, the file descriptor should be ignored. In such a case there is also no need to hold the lock or change the working directory.
This avoids the conversion to an absolute path.
slackner
commented
Nov 30, 2017
| if err != nil { | ||
| t.Fatal(err) | ||
| } | ||
| _, err = os.Stat(tmpDir + "/dir2/f1") |
There was a problem hiding this comment.
Oh, small typo here.
There was a problem hiding this comment.
Or not ... sorry for the noise (thought the path was incorrect, but should be fine - otherwise the tests also wouldn't pass)
|
Looks good to me, thanks! I'll think about emulateRenameat. |
|
Oh and about testing the linux syscalls - that would be nice indeed. I have not found a solution for how to do that without massive copy+paste, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch 1 adds / updates the documentation as requested in #179.
Patch 2 fixes the syscall emulation for absolute paths in a couple of functions. For absolute paths the
dirfdshould always be ignored. BTW, it would be nice if it would be possible to run the same emulation tests with emulation disabled, to test if the Linux syscalls actually work as expected.Patch 3 updates two existing syscall wrappers with the new method (open current directory instead of caching the absolute path)
After this series only
emulateRenameatremains a bit ugly. If you have any suggestions how to improve it without falling back to absolute paths ... ideas welcome ;)