Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenie rejects valid pvar files #492

Closed
Wainberg opened this issue Jan 28, 2024 · 1 comment
Closed

Regenie rejects valid pvar files #492

Wainberg opened this issue Jan 28, 2024 · 1 comment

Comments

@Wainberg
Copy link

regenie/src/Geno.cpp

Lines 791 to 796 in 51968de

if( (tmp_str_vec.size() < 5) ||
(tmp_str_vec[1] != "POS") ||
(tmp_str_vec[2] != "ID") ||
(tmp_str_vec[3] != "REF") ||
(tmp_str_vec[4] != "ALT") )
throw "header of pvar file does not have correct format.";
and

regenie/src/Geno.cpp

Lines 888 to 893 in 51968de

if( (tmp_str_vec.size() < 5) ||
(tmp_str_vec[1] != "POS") ||
(tmp_str_vec[2] != "ID") ||
(tmp_str_vec[3] != "REF") ||
(tmp_str_vec[4] != "ALT") )
throw "header of pvar file does not have correct format.";
reject pvar files if the columns aren't in the usual order - but the pvar specification allows optional columns and doesn't require the columns to be in any particular order if a header is specified. It would be good for regenie to support all valid pvar files.

joellembatchou added a commit that referenced this issue Feb 1, 2024
address issue #492
@joellembatchou
Copy link
Collaborator

Hi,

Thank you for the feedback. This is now handled in v3.4.1.

Cheers,
Joelle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants