Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use srvr, not stat for zxid #99

Merged
merged 2 commits into from
Jan 9, 2019
Merged

Use srvr, not stat for zxid #99

merged 2 commits into from
Jan 9, 2019

Conversation

alxn
Copy link
Contributor

@alxn alxn commented Dec 20, 2018

The stat command includes the connections. When the number of connections is high, it truncates the output, meaning the zxid is not found (and set to -1).

The srvr command only prints out the details on the server, not the connections.

@jeffbean

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 78.617% when pulling d402974 on alxn:use-shorter-command into 1db3eec on rgs1:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 78.617% when pulling d402974 on alxn:use-shorter-command into 1db3eec on rgs1:master.

@coveralls
Copy link

coveralls commented Dec 20, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.04%) to 78.624% when pulling 2b80f27 on alxn:use-shorter-command into 1db3eec on rgs1:master.

@rgs1
Copy link
Owner

rgs1 commented Jan 6, 2019

Thanks @alxn ! LGTM.

@Yasumoto mind taking a look?

@jeffbean
Copy link

jeffbean commented Jan 6, 2019

@jeffbean

lgtm. ty

rgs1
rgs1 reviewed Jan 7, 2019
View reviewed changes
zk_shell/shell.py Outdated Show resolved Hide resolved
@rgs1
Copy link
Owner

rgs1 commented Jan 7, 2019

@alxn @jeffbean actually, there's one potential issue... mind taking a look? Thanks!

@rgs1 rgs1 merged commit afbed80 into rgs1:master Jan 9, 2019
@rgs1
Copy link
Owner

rgs1 commented Jan 9, 2019

Thanks @alxn !

@alxn
Copy link
Contributor Author

alxn commented Jan 9, 2019

@rgs1 thank you!

@alxn alxn deleted the use-shorter-command branch January 9, 2019 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgs1 rgs1 rgs1 left review comments

@jeffbean jeffbean jeffbean left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alxn @coveralls @rgs1 @jeffbean